-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update to btcd v0.23.0 and neutrino v0.14.2 #804
Conversation
b97e082
to
be0ac91
Compare
@@ -196,7 +196,9 @@ func makeDestinationScriptSource(rpcClient *rpcclient.Client, accountName string | |||
// GetNewAddress always returns a P2PKH address since it assumes | |||
// BIP-0044. | |||
newChangeScript := func() ([]byte, error) { | |||
destinationAddress, err := rpcClient.GetNewAddress(accountName) | |||
destinationAddress, err := rpcClient.GetNewAddress( | |||
accountName, "legacy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see #783
It was intended to be merged with btcsuite/btcd#1776 but that slipped by.
That really has to be merged now that 0.23 is tagged with an rpcclient package that sends the address type arg.
Probably too late for btcsuite/btcd#1844 unless you wanna do a 0.23.1 already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, realized I had overlooked that as soon as I had to add this to fix the compilation issue. I spotted another thing we need to patch on the btcd
side as well re a missing return statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, OK that's good then. In that case please consider either btcsuite/btcd#1844 itself or the alternative diff in the comment btcsuite/btcd#1844 (comment) (which causes the address type to be omitted from the marshalled request if the provided type string is ""
)... or any other change you'd prefer! :) Feel free to close any of those and do things differently. I just didn't want to leave rpcclient unusable for the current wallet.
New failures for the pruned block dispatcher:
|
Replaced by #805 |
No description provided.